Re: [PATCH v1] usb: phy: nop: device tree documentation for vbus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Felipe Balbi <balbi@xxxxxx> writes:

> On Sun, Nov 09, 2014 at 02:02:18PM +0100, Robert Jarzmik wrote:
>>  	hsusb1_phy {
>> @@ -26,8 +31,11 @@ Example:
>>  		clock-names = "main_clk";
>>  		vcc-supply = <&hsusb1_vcc_regulator>;
>>  		reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
>> +		vbus-gpios = <&gpio2 13 GPIO_ACTIVE_HIGH>;
>> +		vbus-regulator = <&vbus_regulator>;
>
> not sure why you need vbus-gpios here. You can pass the gpio to the
> regulator as enable-gpio, right ?

Euh no. From my understanding a regulator enable-gpio is an _output_ gpio
enabling the regulator. This vbus-gpio is an _input_ gpio detecting the vbus
assertion. Maybe a name like "vbus-detect-gpio" would be more accurante ?

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux