On 04/04/2023 11:26, Tilki, Ibrahim wrote: >>>> + aux-voltage-chargeable: >>>> + enum: [0, 1, 2] >>>> + description: | >>>> + Enables trickle charger. >>>> + 0: Charger is disabled (default) >>>> + 1: Charger is enabled >>>> + 2: Charger is enabled with a diode >>> >>> 2 is not an allowed value. I asked to drop this property. It is coming >>> from rtc.yaml. I also do not understand "with a diode". So otherwise it >>> is charging with, I don't know, FET? >> >> No, what is not explained here (and maybe not unsterstood by the >> submitter) is that the RTC has an extra diode so, charging will always >> enable a diode, select a resistor and then have or not an extra diode. >> Figure2 of the MAX31329 datasheet is great. >> > > That is exactly why I had "adi,trickle-diode-enable" property in previous patch. > So if I can't have "adi,trickle-diode-enable" and can't add an additional value > to "aux-voltage-chargeable", I am not sure how to add support for the extra > diode at this point. Ask the person who asked you to remove adi,trickle-diode-enable... Anyway even if you decided to go with such advise, the solution is not to create binding which fails. Best regards, Krzysztof
