On 4/4/23 00:55, Heiko Stübner wrote: > Am Montag, 3. April 2023, 19:56:26 CEST schrieb Chris Morgan: >> On Mon, Apr 03, 2023 at 01:50:52PM +0300, Cristian Ciocaltea wrote: >>> Add the necessary DT changes for the Rock 5B board to enable support for >>> the PWM controlled heat sink fan. >> >> Honest question, but should we be adding this to the board file if not >> every device has a PWM fan (they all have the socket for the fan, but >> not the fan)? For example I have a passively cooled case that doesn't >> include a fan. > > We also set up the sdmmc host without knowing if the user will plug in > an sd-card ;-) . > > So especially in the case where there is a dedicated socket for it, > as you write, we should definitly add it for the board. > > By the way, am I correct in thinking that patch 1 and 2 are actually > independent of each other? So I'd just pick patch2 for the Rockchip tree > (as we do have a text-binding) and you can handle the yaml conversion > in a followup or whatever? Yes, the bindings conversion can be handled independently. Thanks, Cristian
