On Mon, Apr 03, 2023 at 01:50:52PM +0300, Cristian Ciocaltea wrote: > Add the necessary DT changes for the Rock 5B board to enable support for > the PWM controlled heat sink fan. Honest question, but should we be adding this to the board file if not every device has a PWM fan (they all have the socket for the fan, but not the fan)? For example I have a passively cooled case that doesn't include a fan. Thank you, Chris Morgan. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > index 95805cb0adfa..bd74d9da2c17 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > @@ -17,6 +17,14 @@ chosen { > stdout-path = "serial2:1500000n8"; > }; > > + fan: pwm-fan { > + compatible = "pwm-fan"; > + cooling-levels = <0 95 145 195 255>; > + fan-supply = <&vcc5v0_sys>; > + pwms = <&pwm1 0 50000 0>; > + #cooling-cells = <2>; > + }; > + > vcc5v0_sys: vcc5v0-sys-regulator { > compatible = "regulator-fixed"; > regulator-name = "vcc5v0_sys"; > @@ -27,6 +35,10 @@ vcc5v0_sys: vcc5v0-sys-regulator { > }; > }; > > +&pwm1 { > + status = "okay"; > +}; > + > &sdhci { > bus-width = <8>; > no-sdio; > -- > 2.40.0 >