On 03/04/2023 13:40, Edmund Berenson wrote: > Add driver documentation for the maxim max7317 spi > gpio expander. Subject: drop second/last, redundant "documentation". The "dt-bindings" prefix is already stating that these are bindings and documentation. > > Co-developed-by: Lukasz Zemla <Lukasz.Zemla@xxxxxxxxxxxx> > Signed-off-by: Lukasz Zemla <Lukasz.Zemla@xxxxxxxxxxxx> > Signed-off-by: Edmund Berenson <edmund.berenson@xxxxxxxxx> > --- This is v2, so where is the changelog? No cover letter, either. > .../bindings/gpio/gpio-max7317.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-max7317.yaml Filename must be like compatible. "gpio" is not a vendor prefix. maxim,max7317.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-max7317.yaml b/Documentation/devicetree/bindings/gpio/gpio-max7317.yaml > new file mode 100644 > index 000000000000..ad5a796c704e > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-max7317.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/gpio-max7317.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX7317 SPI-Interfaced I/O Expander > + > +maintainers: > + - Edmund Berenson <edmund.berenson@xxxxxxxxx> > + > +description: > + Bindings for 10-Port Maxim MAX7317 SPI GPIO expanders. Describe the hardware, not the "bindings". Drop "Bindings for". > + > +properties: > + compatible: > + const: maxim,max7317 > + > + reg: > + maxItems: 1 > + > + gpio-controller: true > + > + '#gpio-cells': Use consistent quotes, either ' or ". > + const: 2 > + > +required: > + - compatible > + - reg > + - gpio-controller > + - "#gpio-cells" > + > +unevaluatedProperties: false > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# Fix ordering. allOf goes either before properties or before unevaluatedProps. See for example example-schema. > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; Use 4 spaces for example indentation. > + Best regards, Krzysztof
