On 03-04-23, 14:31, Changhuang Liang wrote: > > > On 2023/4/3 14:24, Conor Dooley wrote: > > On Mon, Apr 03, 2023 at 09:39:00AM +0800, Changhuang Liang wrote: > >> On 2023/3/31 21:52, Vinod Koul wrote: > >>> On 21-03-23, 14:08, Changhuang Liang wrote: > >>>> On 2023/3/20 20:37, Vinod Koul wrote: > >>>>> On 22-02-23, 17:59, Changhuang Liang wrote: > >>>>>> +static int stf_dphy_configure(struct phy *phy, union phy_configure_opts *opts) > >>>>>> +{ > >>>>>> + struct stf_dphy *dphy = phy_get_drvdata(phy); > >>>>>> + int map[6] = {4, 0, 1, 2, 3, 5}; > >>>>> > >>>>> what does this mean? > >>>> > >>>> This is the physical lane and logical lane mapping table, should I add a note for it? > >>> > >>> Yes please. Also will the mapping be always static or ever change? > >>> > >> > >> The mapping is always static on the visionfive2 single board computer. > >> Thanks for your comments. > > > > What about other boards featuring a JH7110? > > maybe add this mapping in the device tree, we just need to parse the device tree is better. If the mapping is hw description then yes it makes sense -- ~Vinod