Hi Rob, On Fri, Mar 31, 2023 at 6:28 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote: > On Fri, Mar 31, 2023 at 2:52 AM Geert Uytterhoeven > <geert+renesas@xxxxxxxxx> wrote: > > Reshuffle the code to get rid of the forward declarations, which > > improves readability. > > Is git blame smart enough to ignore this move? If not, I'd rather keep > the blame than save 3 lines. Apparently (I didn't know before ;-), it is, when using the -M option: $ git blame -- drivers/of/address.c | tail -3 1db096f9167bc267e (Geert Uytterhoeven 2023-03-30 13:42:05 +0200 1150) return mem; 1db096f9167bc267e (Geert Uytterhoeven 2023-03-30 13:42:05 +0200 1151) } 1db096f9167bc267e (Geert Uytterhoeven 2023-03-30 13:42:05 +0200 1152) EXPORT_SYMBOL(of_io_request_and_map); $ git blame -M -- drivers/of/address.c | tail -3 efd342fb0031a1775 (Matthias Brugger 2014-07-18 11:36:39 +0200 1150) return mem; efd342fb0031a1775 (Matthias Brugger 2014-07-18 11:36:39 +0200 1151) } efd342fb0031a1775 (Matthias Brugger 2014-07-18 11:36:39 +0200 1152) EXPORT_SYMBOL(of_io_request_and_map); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds