Re: Subject: [PATCH v1 1/2] dt-bindings: arm: realtek: Add Realtek Pym Particles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/03/2023 11:58, CY_Huang[黃鉦晏] wrote:
> Define a compatible string for Realtek RTD1319 Pym Particles eval board.
> 
> Signed-off-by: cy.huang <mailto:cy.huang@xxxxxxxxxxx>

Your patch has corrupted subject.
> ---
> 
> v1:
> * RTD1319 SoC and Realtek PymParticle EVB

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

> 
> Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
> index ddd9a85099e9..8d4e92e9eb4b 100644
> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> @@ -55,6 +55,12 @@ properties:
>                - realtek,mjolnir # Realtek Mjolnir EVB
>            - const: realtek,rtd1619
> 
> +      # RTD1319 SoC based boards
> +      - items:
> +          - enum:
> +              - realtek,pym-particles # Realtek Pym-particles EVB
> +          - const: realtek,rtd1319

Wrong placement - these are ordered by SoC. Don't add stuff just at the end.

> +
> additionalProperties: true
> 
> ...
> --
> 2.39.0

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux