Hi Okan, thanks for your patch! First: why is the word "Regulator" in the subject? I don't quite get it. On Mon, Mar 27, 2023 at 3:01 PM Okan Sahin <okan.sahin@xxxxxxxxxx> wrote: > > Gpio I/O expander. > > Signed-off-by: Okan Sahin <okan.sahin@xxxxxxxxxx> This commit log is too terse. Write a bit about what this hardware is. > +config GPIO_DS4520 > + tristate "DS4520 I2C GPIO expander" > + select REGMAP_I2C > + help > + GPIO driver for Maxim MAX7300 I2C-based GPIO expander. Is it MAX7300, I don't get this, it seems super-confused. > + Say yes here to enable the GPIO driver for the ADI DS4520 chip. > + > + To compile this driver as a module, choose M here: the module will > + be called gpio-ds4520. (...) The driver is pretty straight-forward, but I think this can use the generic GPIO_REGMAP helpers in drivers/gpio/gpio-regmap.c check other drivers selecting this helper library for inspiration. Yours, Linus Walleij
