Re: [PATCH 1/3] arm64: dts: ti: k3-j784s4-main: Add MAIN domain R5F cluster nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/29/23 07:52, Nishanth Menon wrote:
     MAIN R5FSS0 Core0: j784s4-main-r5f0_0-fw (both in LockStep and Split modes)
     MAIN R5FSS0 Core1: j784s4-main-r5f0_1-fw (needed only in Split mode)
     MAIN R5FSS1 Core0: j784s4-main-r5f1_0-fw (both in LockStep and Split modes)
     MAIN R5FSS1 Core1: j784s4-main-r5f1_1-fw (needed only in Split mode)
     MAIN R5FSS2 Core0: j784s4-main-r5f2_0-fw (both in LockStep and Split modes)
     MAIN R5FSS2 Core1: j784s4-main-r5f2_1-fw (needed only in Split mode)
Why are the patches split up into main and mcu - if you are adding r5f
cores, do them as a single patch.

Thought would be cleaner with separated patches for resolving potential merge conflicts. But, can combine into one for v2.

>> +
>> +	main_r5fss0: r5fss@5c00000 {
>> +		compatible = "ti,j721s2-r5fss";
>> +		ti,cluster-mode = <1>;
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
>> +		ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
>> +			 <0x5d00000 0x00 0x5d00000 0x20000>;
>> +		power-domains = <&k3_pds 336 TI_SCI_PD_EXCLUSIVE>;
>> +
>> +		main_r5fss0_core0: r5f@5c00000 {
>> +			compatible = "ti,j721s2-r5f";
>> +			reg = <0x5c00000 0x00010000>,
>> +			      <0x5c10000 0x00010000>;
>> +			reg-names = "atcm", "btcm";
>> +			ti,sci = <&sms>;
>> +			ti,sci-dev-id = <339>;
>> +			ti,sci-proc-ids = <0x06 0xff>;
>> +			resets = <&k3_reset 339 1>;
>> +			firmware-name = "j784s4-main-r5f0_0-fw";
>> +			ti,atcm-enable = <1>;
>> +			ti,btcm-enable = <1>;
>> +			ti,loczrama = <1>;
>> +			status = "disabled";
> Why are these disabled by default?
Well, the idea is to let the board specific device tree enable needed remote core nodes in *-evm/sk.dts and disable by default in SoC device tree files by default.



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux