Re: [PATCH v5 09/10] ARM: dts: stm32: add STM32MP1-based Phytec SoM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi steffen


On 3/21/23 08:14, Steffen Trumtrar wrote:

Hi Alexandre,

Alexandre TORGUE <alexandre.torgue@xxxxxxxxxxx> writes:

[1. text/plain]
Hi Steffen

On 3/20/23 14:27, Steffen Trumtrar wrote:
The Phytec STM32MP1 based SoMs feature up to 1 GB DDR3LP RAM, up to 1 GB
eMMC, up to 16 MB QSPI and up to 128 GB NAND flash.
Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
---
Notes:
      checkpatch warns about un-documented binding
           According to checkpatch the binding for "winbond,w25q128"
      used in this dtsi is un-documented.
      However, 'jedec,spi-nor.yaml' defines the pattern
               (winbond,)?w25q(16|32(w|dw)?|64(dw)?|80bl|128(fw)?|256))$"
           so, this should be good!?

We recently added some yaml fixes and we continue to send others (i.e., GPU yaml
error fix is under review) so please don't add new ones. Some of follownig
errors are directly linked to your board so please fix them.


sorry about that, seems like I wasn't using dt_binding_check correctly :(
However, how did you generate these?

I ran make dtbs_check (after updating my schemes).

Cheers
Alex



arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dtb:
/soc/i2c@40012000/touch@44: failed to match any schema with compatible:
['st,stmpe811']
arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dtb:
/soc/i2c@40012000/touch@44/touchscreen: failed to match any schema with
compatible: ['st,stmpe-ts']
arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dtb: /soc/i2c@40012000/leds@62:
failed to match any schema with compatible: ['nxp,pca9533']

The bindings are there and if I explicitly run dt_bindings_check with
e.g. Documentation/devicetree/bindings/leds there is no warning/error.

I will fixup the rest.

Best regards,
Steffen

--
Pengutronix e.K.                | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux