On 27/03/2023 11:30, Varadarajan Narayanan wrote: > Document the IPQ9574 dwc3 compatible. > > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> > --- > Changes in v4: > - Update other relevant sections > - Remove constraints not applicable to IPQ9574 No, that's not way to go. These are required. > --- > .../devicetree/bindings/usb/qcom,dwc3.yaml | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > index a2aabda..3fc8c3c 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > @@ -17,6 +17,7 @@ properties: > - qcom,ipq6018-dwc3 > - qcom,ipq8064-dwc3 > - qcom,ipq8074-dwc3 > + - qcom,ipq9574-dwc3 > - qcom,msm8953-dwc3 > - qcom,msm8994-dwc3 > - qcom,msm8996-dwc3 > @@ -132,11 +133,8 @@ required: > - "#address-cells" > - "#size-cells" > - ranges > - - power-domains > - clocks > - clock-names > - - interrupts > - - interrupt-names > > allOf: > - if: > @@ -242,6 +240,24 @@ allOf: > compatible: > contains: > enum: > + - qcom,ipq9574-dwc3 > + then: > + properties: > + clocks: > + maxItems: 5 > + clock-names: > + items: > + - const: sys_noc_axi > + - const: anoc_axi Heh, do we really need entirely different clock names for each new variant? Best regards, Krzysztof
