On 26/03/2023 14:29, Aleksander Jan Bajkowski wrote: > Document the legacy Lantiq device tree bindings. This suggests you are documenting existing compatibles, but I do not see them at all. Confusing. > Compatible strings for xRX100 (ar9) and newer SoCs Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > should be renamed and will be added later. Subject: drop second/last, redundant "dt bindings". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Aleksander Jan Bajkowski <olek2@xxxxx> > --- > .../devicetree/bindings/mips/lantiq/soc.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mips/lantiq/soc.yaml > > diff --git a/Documentation/devicetree/bindings/mips/lantiq/soc.yaml b/Documentation/devicetree/bindings/mips/lantiq/soc.yaml > new file mode 100644 > index 000000000000..90e8148b111b > --- /dev/null > +++ b/Documentation/devicetree/bindings/mips/lantiq/soc.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mips/lantiq/soc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lantiq SoC based Platform > + > +maintainers: > + - Aleksander Jan Bajkowski <olek2@xxxxx> > + > +description: > + Devices with a Lantiq CPU shall have the following properties. > + > +properties: > + $nodename: > + const: "/" > + compatible: > + oneOf: > + - description: Boards with Lantiq Amazon-SE SoC > + items: > + - const: lantiq,ase This does not look like proper board compatible. Boards have almost always minimum two compatibles - one for SoC and one for board. With commit msg this just adds to confusion... Best regards, Krzysztof
