On Wed, 19 Nov 2014, Beomho Seo wrote: > This patch adds a new driver for Richtek RT5033 driver. > RT5033 is a Multifunction device which includes battery charger, fuel gauge, > flash LED current source, LDO and synchronous Buck converter. It is interfaced > to host controller using I2C interface. > > Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> > Cc: Lee Jones <lee.jone@xxxxxxxxxx> > Signed-off-by: Beomho Seo <beomho.seo@xxxxxxxxxxx> > Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > --- > Changes in v5 > - Change possible built as a module. > - Revise rt5033_dev mfd cell entry. > - Fix incorrect typo. > - Add module alias. > > Changes in v4 > - none. > > Changes in v3 > - Correct sentence errors. > - Add author information the top of each drivers. > - Remove unnecessary pre-initialise, struct member(rt5033->i2c) and blink. > - Change some return check. > - Use bool and of_match_ptr(). > > Changes in v2 > - Remove volatile_reg callback. Because this driver not in use regmap cache. > - Revmoe unnecessary subnode of_compatible. > - Add define for set_high impedance mode of charger. > --- > drivers/mfd/Kconfig | 12 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/rt5033.c | 136 +++++++++++++++++++ > include/linux/mfd/rt5033-private.h | 260 ++++++++++++++++++++++++++++++++++++ > include/linux/mfd/rt5033.h | 62 +++++++++ > 5 files changed, 471 insertions(+) > create mode 100644 drivers/mfd/rt5033.c > create mode 100644 include/linux/mfd/rt5033-private.h > create mode 100644 include/linux/mfd/rt5033.h > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 72d3808..9c13170 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -618,6 +618,18 @@ config MFD_RTSX_PCI > types of memory cards, such as Memory Stick, Memory Stick Pro, > Secure Digital and MultiMediaCard. > > +config MFD_RT5033 > + tristate "Richtek RT5033 Power Management IC" > + depends on I2C=y > + select MFD_CORE > + select REGMAP_I2C > + help > + This driver provides for the Richtek RT5033 Power Management IC, > + which includes the I2C driver and the Core APIs. This driver provides > + common support for accessing the device. The device supports multiple > + sub-devices like charger, fuel gauge, flash LED, current source, > + LDO and Buck. > + > config MFD_RTSX_USB > tristate "Realtek USB card reader" > depends on USB > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 53467e2..4059c24 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -176,6 +176,7 @@ obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o > obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o > obj-$(CONFIG_MFD_HI6421_PMIC) += hi6421-pmic-core.o > obj-$(CONFIG_MFD_DLN2) += dln2.o > +obj-$(CONFIG_MFD_RT5033) += rt5033.o > > intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o > obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o > diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c > new file mode 100644 > index 0000000..4d289b9 > --- /dev/null > +++ b/drivers/mfd/rt5033.c > @@ -0,0 +1,136 @@ > +/* > + * MFD core driver for the Richtek RT5033. > + * > + * Copyright (C) 2014 Samsung Electronics, Co., Ltd. > + * Author: Beomho Seo <beomho.seo@xxxxxxxxxxx> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published bythe Free Software Foundation. > + */ > + > +#include <linux/err.h> > +#include <linux/module.h> > +#include <linux/interrupt.h> > +#include <linux/of_device.h> > +#include <linux/mfd/core.h> > +#include <linux/mfd/rt5033.h> > +#include <linux/mfd/rt5033-private.h> > + > +static const struct regmap_irq rt5033_irqs[] = { > + { .mask = RT5033_PMIC_IRQ_BUCKOCP, }, > + { .mask = RT5033_PMIC_IRQ_BUCKLV, }, > + { .mask = RT5033_PMIC_IRQ_SAFELDOLV, }, > + { .mask = RT5033_PMIC_IRQ_LDOLV, }, > + { .mask = RT5033_PMIC_IRQ_OT, }, > + { .mask = RT5033_PMIC_IRQ_VDDA_UV, }, > +}; > + > +static const struct regmap_irq_chip rt5033_irq_chip = { > + .name = "rt5033", > + .status_base = RT5033_REG_PMIC_IRQ_STAT, > + .mask_base = RT5033_REG_PMIC_IRQ_CTRL, > + .mask_invert = true, > + .num_regs = 1, > + .irqs = rt5033_irqs, > + .num_irqs = ARRAY_SIZE(rt5033_irqs), > +}; > + > +static const struct mfd_cell rt5033_devs[] = { > + { .name = "rt5033-regulator", }, > + { .name = "rt5033-charger", .of_compatible = "richtek,rt5033-charger",}, > + { .name = "rt5033-battery", .of_compatible = "richtek,rt5033-battery",}, > +}; Perhaps I wasn't clear enough in my previous review -- sorry for that. I only want to see the single entry on one line i.e. one with .name, but no .of_compatible. I probably wouldn't have requested a re-spin, but you have white space issues at the end of those two lines too. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html