Re: [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/21/2023 11:01 PM, Krzysztof Kozlowski wrote:
On 21/03/2023 14:51, Souradeep Chowdhury wrote:
All Qualcomm bootloaders log useful timestamp information related
to bootloader stats in the IMEM region. Add the child node within
IMEM for the boot stat region containing register address and
compatible string.

Signed-off-by: Souradeep Chowdhury <quic_schowdhu@xxxxxxxxxxx>
---
  .../devicetree/bindings/sram/qcom,imem.yaml          | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
index 665c06e..c8c3890 100644
--- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
+++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
@@ -48,6 +48,26 @@ patternProperties:
      $ref: /schemas/remoteproc/qcom,pil-info.yaml#
      description: Peripheral image loader relocation region
+ "^boot-stat@[0-9a-f]+$":
+    type: object
+    description:
+      node for boot stat.

This basically copies the name of node, so not really helpful. Describe
what's this.

Ack

+

additionalProperties: false

+    properties:
+      compatible:
+        items:

Drop items.

+          - const: qcom,imem-boot_stats

No underscores in compatibles. Why this is not SoC specific compatible?

Ack. The boot_stats module is not specific to a device. It is written to
read some values from this imem region which is present for almost all QCOM SoCs. So SoC specific compatible is not given in this case.


+
+      reg:
+        maxItems: 1
+        description:
+          The base address of the register region in case of
+          imem boot stats.

Drop description, it's obvious.

Ack
+
+    required:
+      - compatible
+      - reg
+
Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux