Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Tuesday, March 21, 2023 8:36 AM
> To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>;
> linux-renesas-soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Prabhakar
> Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v3 5/5] arm64: dts: renesas: r9a07g044: Enable sci0
> nodes using dt overlay
>
> Hi Biju,
>
> On Tue, Mar 21, 2023 at 9:23 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > > -----Original Message-----
> > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > Sent: Monday, March 20, 2023 7:15 PM
> > > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> > > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Geert Uytterhoeven
> > > <geert+renesas@xxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>;
> > > linux- renesas-soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> > > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > > Subject: Re: [PATCH v3 5/5] arm64: dts: renesas: r9a07g044: Enable
> > > sci0 nodes using dt overlay
> > >
> > > On Mon, Mar 20, 2023 at 11:54 AM Biju Das
> > > <biju.das.jz@xxxxxxxxxxxxxx>
> > > wrote:
> > > > Enable sci0 node using dt overlay and disable can{0,1}-stb-hog
> > > > nodes in dt overlay as its pins are shared with sci0 pins.
> > > >
> > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > > ---
> > > > v3:
> > > > * New patch
> > >
> > > Thanks for your patch!
> > >
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/renesas/r9a07g043-smarc.dtso
> > >
> > > Can you please come up with a better filename?
> > > Perhaps r9a07g043-smarc-pmod.dtso?
> >
> > Agreed.
>
> > > > +#include <dt-bindings/pinctrl/rzg2l-pinctrl.h>
> > > > +
> > > > +&pinctrl {
> > > > + can0-stb-hog {
> > > > + status = "disabled";
> > > > + };
> > > > +
> > > > + can1-stb-hog {
> > > > + status = "disabled";
> > > > + };
> > > > +
> > > > + sci0_pins: sci0-pins {
> > > > + pinmux = <RZG2L_PORT_PINMUX(2, 2, 5)>, /* TxD */
> > > > + <RZG2L_PORT_PINMUX(2, 3, 5)>; /* RxD */
> > > > + };
> >
> > Next version, I am planning to move this pinctrl definitions to
> > rzg2ul-smarc-pinfunction.dtsi as separate patch, since it is SoC specific?
>
> r9a07g043-smarc-pmod.dtso is SoC-specific, too?
Got it. It is SoC specific. No need to move the definitions.
Cheers,
Biju
> Or do you want to drop the r9a07g043-prefix?
>
> > +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi
> > @@ -50,6 +50,13 @@ i2c1_pins: i2c1 {
> > input-enable;
> > };
> >
> > +#if (SW_ET0_EN_N)
> > + sci0_pins: sci0-pins {
> > + pinmux = <RZG2L_PORT_PINMUX(2, 2, 5)>, /* TxD */
> > + <RZG2L_PORT_PINMUX(2, 3, 5)>; /* RxD */
> > + };
> > +#endif
>
> > > > +};
> > > > +
> > > > +&sci0 {
> > > > + pinctrl-0 = <&sci0_pins>;
> > > > + pinctrl-names = "default";
> > > > + status = "okay";
> > > > +};
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
