Re: [PATCH v3 5/5] arm64: dts: renesas: r9a07g044: Enable sci0 nodes using dt overlay

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

On Mon, Mar 20, 2023 at 11:54 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Enable sci0 node using dt overlay and disable can{0,1}-stb-hog
> nodes in dt overlay as its pins are shared with sci0 pins.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v3:
>  * New patch

Thanks for your patch!

> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r9a07g043-smarc.dtso

Can you please come up with a better filename?
Perhaps r9a07g043-smarc-pmod.dtso?

> @@ -0,0 +1,45 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Device Tree Source for the RZ/{G2UL, Five} SMARC EVK PMOD parts
> + *
> + * Copyright (C) 2023 Renesas Electronics Corp.
> + *
> + *
> + * [Connection]
> + *
> + * SMARC EVK                           PMOD USBUART
> + * +----------------------------+
> + * |CN7 (PMOD1 PIN HEADER)     |
> + * |   SCI0_TXD          pin7  |<----->| pin2  Tx      |
> + * |   SCI1_RXD          pin8  |<----->| pin3  Rx      |
> + * |   Gnd               pin11 |<----->| pin5  Gnd     |
> + * |   Vcc               pin12 |<----->| pin6  Vcc     |
> + * +----------------------------+      +---------------+

I don't think the right side of this diagram belongs here. The user
is not limited to a USB-UART bridge, but can connect whatever he wants
to the PMOD connector.

> + *
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +#include <dt-bindings/gpio/gpio.h>

Unused?

> +#include <dt-bindings/pinctrl/rzg2l-pinctrl.h>
> +
> +&pinctrl {
> +       can0-stb-hog {
> +               status = "disabled";
> +       };
> +
> +       can1-stb-hog {
> +               status = "disabled";
> +       };
> +
> +       sci0_pins: sci0-pins {
> +               pinmux = <RZG2L_PORT_PINMUX(2, 2, 5)>, /* TxD */
> +                        <RZG2L_PORT_PINMUX(2, 3, 5)>; /* RxD */
> +       };
> +};
> +
> +&sci0 {
> +       pinctrl-0 = <&sci0_pins>;
> +       pinctrl-names = "default";
> +       status = "okay";
> +};

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux