Hello, > -----Original Message----- > From: Andi Shyti <andi.shyti@xxxxxxxxxx> > Sent: Saturday, March 18, 2023 5:10 PM > To: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx> > Cc: Andrew Jeffery <andrew@xxxxxxxx>; Brendan Higgins > <brendan.higgins@xxxxxxxxx>; Benjamin Herrenschmidt > <benh@xxxxxxxxxxxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; Rob Herring > <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Philipp Zabel > <p.zabel@xxxxxxxxxxxxxx>; linux-i2c@xxxxxxxxxxxxxxx; > openbmc@xxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for > AST2600-i2cv2 > > Hi Ryan, > > On Sun, Feb 26, 2023 at 11:13:20AM +0800, Ryan Chen wrote: > > Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout > > aspeed,xfer-mode description for ast2600-i2cv2. > > > > Signed-off-by: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 > +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > index f597f73ccd87..75de3ce41cf5 100644 > > --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > @@ -49,6 +49,25 @@ properties: > > description: > > states that there is another master active on this bus > > > > + aspeed,timeout: > > + type: boolean > > + description: I2C bus timeout enable for master/slave mode > > Finally you can proceed with this. Please remove "aspeed,timeout" > and use "i2c-scl-has-clk-low-timeout" instead. Thanks a lot, I will start progress this. Best Regards Ryan