Hi Keguang, I love your patch! Yet something to improve: [auto build test ERROR on 6f173737e1b5670c200329677e821cce1d3d755e] url: https://github.com/intel-lab-lkp/linux/commits/Keguang-Zhang/dt-bindings-clock-Add-Loongson-1-clock/20230316-185026 base: 6f173737e1b5670c200329677e821cce1d3d755e patch link: https://lore.kernel.org/r/20230316104707.236034-4-keguang.zhang%40gmail.com patch subject: [PATCH v3 3/4] clk: loongson1: Re-implement the clock driver config: mips-loongson1c_defconfig (https://download.01.org/0day-ci/archive/20230318/202303181358.BXLJVMkh-lkp@xxxxxxxxx/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mipsel-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/de00eab744ddc82edb1853048dd5d50aa8220115 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Keguang-Zhang/dt-bindings-clock-Add-Loongson-1-clock/20230316-185026 git checkout de00eab744ddc82edb1853048dd5d50aa8220115 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303181358.BXLJVMkh-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/clk/clk-loongson1.c:300:15: error: expected parameter declarator MODULE_AUTHOR("Keguang Zhang <keguang.zhang@xxxxxxxxx>"); ^ >> drivers/clk/clk-loongson1.c:300:15: error: expected ')' drivers/clk/clk-loongson1.c:300:14: note: to match this '(' MODULE_AUTHOR("Keguang Zhang <keguang.zhang@xxxxxxxxx>"); ^ >> drivers/clk/clk-loongson1.c:300:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int] MODULE_AUTHOR("Keguang Zhang <keguang.zhang@xxxxxxxxx>"); ^ int >> drivers/clk/clk-loongson1.c:300:14: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] MODULE_AUTHOR("Keguang Zhang <keguang.zhang@xxxxxxxxx>"); ^ void drivers/clk/clk-loongson1.c:301:20: error: expected parameter declarator MODULE_DESCRIPTION("Loongson1 clock driver"); ^ drivers/clk/clk-loongson1.c:301:20: error: expected ')' drivers/clk/clk-loongson1.c:301:19: note: to match this '(' MODULE_DESCRIPTION("Loongson1 clock driver"); ^ drivers/clk/clk-loongson1.c:301:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int] MODULE_DESCRIPTION("Loongson1 clock driver"); ^ int drivers/clk/clk-loongson1.c:301:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] MODULE_DESCRIPTION("Loongson1 clock driver"); ^ void 8 errors generated. vim +300 drivers/clk/clk-loongson1.c 299 > 300 MODULE_AUTHOR("Keguang Zhang <keguang.zhang@xxxxxxxxx>"); -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
