Hi Christian, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/net-dsa-qca8k-add-LEDs-basic-support/20230308-063832 patch link: https://lore.kernel.org/r/20230307170046.28917-2-ansuelsmth%40gmail.com patch subject: [net-next PATCH 01/11] net: dsa: qca8k: add LEDs basic support config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20230317/202303170529.8ag9rmM4-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/ce1977c679b8737815636b72f4e65c2de59e8f7d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Christian-Marangi/net-dsa-qca8k-add-LEDs-basic-support/20230308-063832 git checkout ce1977c679b8737815636b72f4e65c2de59e8f7d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/dsa/qca/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303170529.8ag9rmM4-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/net/dsa/qca/qca8k-leds.c:171:1: error: redefinition of 'qca8k_setup_led_ctrl' 171 | qca8k_setup_led_ctrl(struct qca8k_priv *priv) | ^~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/dsa/qca/qca8k-leds.c:5: drivers/net/dsa/qca/qca8k.h:577:19: note: previous definition of 'qca8k_setup_led_ctrl' with type 'int(struct qca8k_priv *)' 577 | static inline int qca8k_setup_led_ctrl(struct qca8k_priv *priv) | ^~~~~~~~~~~~~~~~~~~~ vim +/qca8k_setup_led_ctrl +171 drivers/net/dsa/qca/qca8k-leds.c 169 170 int > 171 qca8k_setup_led_ctrl(struct qca8k_priv *priv) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
