> Just checked them, interesting concept, guess we can think of something > also for the interval setting. That would effectively make all the > setting of the trigger set. Just my concern is that they may be too much > specific to netdev trigger and may be problematic for other kind of hw > control. (one main argument that was made for this feature was that some > stuff were too much specific and actually not that generic) I deliberately made this API return a struct device, not a struct net_device. That should keep it generic. The LED could then be attached to an disk device, an mtd device, or a tty device, each of which have an ledtrig-*.c file. Andrew