On 18/11/14 10:03, Arnd Bergmann wrote: > On Tuesday 18 November 2014 09:45:17 James Hogan wrote: >> On 18/11/14 00:26, Andrew Bresticker wrote: >>> Hi Naidu, >>> >>> On Mon, Nov 17, 2014 at 4:12 PM, Naidu Tellapati >>> <Naidu.Tellapati@xxxxxxxxxx> wrote: >>>> Hi Andrew, >>>> >>>> (We will respond to James Hogan's remaining review comments in a separate email) >>>> >>>>>> >>>>>> +obj-$(CONFIG_SOC_IMG) += pistachio/ >>>> >>>>> What is CONFIG_SOC_IMG? It sounds very generic. >>>> >>>> May I have your suggestions on the above. >>>> >>>> (Assuming we create drivers/soc/img/ instead of drivers/soc/pistachio/) >> >> What would "belong" in there? >> Basically anything that doesn't belong in some particular subsystem? >> >> > > I think we have reached the threshold of needing a proper subsystem for > efuse/otp devices, and we should move the existing drivers into one > common directory and find a maintainer who can generalize the interfaces. In case anybody is interested, Zubair summarised sunxi and JZ4780 efuse contents here: https://groups.google.com/d/msg/mips-creator-ci20-dev/-PeqbbifWAQ/Y-tQQfnHqEwJ It'd be interesting to hear what the IMG one is intended to hold. Cheers James
Attachment:
signature.asc
Description: OpenPGP digital signature