Hi Naidu, On Mon, Nov 17, 2014 at 4:12 PM, Naidu Tellapati <Naidu.Tellapati@xxxxxxxxxx> wrote: > Hi Andrew, > > (We will respond to James Hogan's remaining review comments in a separate email) > >>> >>> +obj-$(CONFIG_SOC_IMG) += pistachio/ > >> What is CONFIG_SOC_IMG? It sounds very generic. > > May I have your suggestions on the above. > > (Assuming we create drivers/soc/img/ instead of drivers/soc/pistachio/) I don't have much visibility into ImgTec SoCs other than Pistachio, but I think introducing a SOC_IMG Kconfig symbol is a good idea as it gives drivers for various pieces of IP present on ImgTec SoCs (watchdog, I2C, DMA, etc.) a more specific dependency than say MIPS or METAG. Maybe James has a suggestion for how to deal with this? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html