On 16/03/2023 11:18, Guo Samin wrote: > > > -------- 原始信息 -------- > Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > to : Guo Samin <samin.guo@xxxxxxxxxxxxxxxx>, linux-riscv@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx > data: 2023/3/16 > >> On 16/03/2023 09:28, Guo Samin wrote: >>> >>> >>> -------- 原始信息 -------- >>> 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac >>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>> 收件人: Guo Samin <samin.guo@xxxxxxxxxxxxxxxx>, linux-riscv@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx >>> 日期: 2023/3/16 >>> >>>> On 16/03/2023 09:15, Guo Samin wrote: >>>>>>>> interrupts: ??? >>>>>>>> >>>>>>> >>>>>>> Hi Krzysztof, >>>>>>> >>>>>>> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, >>>>>>> and the JH7110 SoC is also applicable. >>>>>>> Maybe just add reg/interrupt/interrupt-names to the required ? >>>>>> >>>>>> You need to constrain them. >>>>> >>>>> >>>>> I see. I will add reg constraints in the next version, thanks. >>>>> >>>>> I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml, >>>>> do these also need to be constrained? >>>> >>>> The interrupts on common binding are variable, so you need to constrain >>>> them - you have fixed number of them, right? >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> >>> Yes, JH7110 fixed is 3 pcs. Thanks, I will constrain them. >> >> Then just minItems: 3, maxItems: 3 here should be enough >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > Thank you for the suggestion. > I'll change it like this in the next version, is right? Yes, looks good for me. Best regards, Krzysztof
