On 16/03/2023 09:02, Guo Samin wrote: > > > -------- 原始信息 -------- > 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > 收件人: Samin Guo <samin.guo@xxxxxxxxxxxxxxxx>, linux-riscv@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx > 日期: 2023/3/16 > >> On 16/03/2023 05:37, Samin Guo wrote: >>> From: Yanhong Wang <yanhong.wang@xxxxxxxxxxxxxxxx> >>> >>> Add documentation to describe StarFive dwmac driver(GMAC). >>> >> Thank you for your patch. There is something to discuss/improve. >> >>> Signed-off-by: Yanhong Wang <yanhong.wang@xxxxxxxxxxxxxxxx> >>> Signed-off-by: Samin Guo <samin.guo@xxxxxxxxxxxxxxxx> >>> Tested-by: Tommaso Merciai <tomm.merciai@xxxxxxxxx> >>> --- >>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >>> .../bindings/net/starfive,jh7110-dwmac.yaml | 130 ++++++++++++++++++ >>> MAINTAINERS | 6 + >>> 3 files changed, 137 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> index e4519cf722ab..245f7d713261 100644 >>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> @@ -91,6 +91,7 @@ properties: >>> - snps,dwmac-5.20 >>> - snps,dwxgmac >>> - snps,dwxgmac-2.10 >>> + - starfive,jh7110-dwmac >>> >>> reg: >>> minItems: 1 >>> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>> new file mode 100644 >>> index 000000000000..b59e6bd8201f >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>> @@ -0,0 +1,130 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +# Copyright (C) 2022 StarFive Technology Co., Ltd. >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: StarFive JH7110 DWMAC glue layer >>> + >>> +maintainers: >>> + - Emil Renner Berthing <kernel@xxxxxxxx> >>> + - Samin Guo <samin.guo@xxxxxxxxxxxxxxxx> >>> + >>> +select: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - starfive,jh7110-dwmac >>> + required: >>> + - compatible >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - starfive,jh7110-dwmac >>> + - const: snps,dwmac-5.20 >>> + >> >> reg: >> maxItems: 1 > >> >>> + clocks: >>> + items: >>> + - description: GMAC main clock >>> + - description: GMAC AHB clock >>> + - description: PTP clock >>> + - description: TX clock >>> + - description: GTX clock >>> + >>> + clock-names: >>> + items: >>> + - const: stmmaceth >>> + - const: pclk >>> + - const: ptp_ref >>> + - const: tx >>> + - const: gtx >>> + >> >> interrupts: ??? >> > > Hi Krzysztof, > > snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, > and the JH7110 SoC is also applicable. > Maybe just add reg/interrupt/interrupt-names to the required ? You need to constrain them. > > > required: > - compatible > + - reg > - clocks > - clock-names > + - interrupts > + - interrupt-names > - resets > - reset-names Best regards, Krzysztof
