On 15.03.2023 23:36, Bjorn Andersson wrote: > On Thu, Mar 16, 2023 at 02:31:45AM +0530, Bhupesh Sharma wrote: >> Add DTS for Qualcomm qrb4210-rb2 board which uses SM4250 SoC. >> >> This adds debug uart, emmc, uSD and tlmm support along with >> regulators found on this board. >> >> Also defines the 'xo_board' and 'sleep_clk' frequencies for >> this board. >> >> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> >> --- [...] >> + vmmc-supply = <&vreg_l24a_2p96>; > > Is there any reason why this platform doesn't require the vmmc supply to > be driven to HPM? This has traditionally been coming back biting us > through some stability issues later. Do we even support HPM/LPM on SMD RPM? Konrad > > Regards, > Bjorn > >> + vqmmc-supply = <&vreg_l11a_1p8>; >> + no-sdio; >> + non-removable; >> +}; >> + >> +&sdhc_2 { >> + status = "okay"; >> + >> + cd-gpios = <&tlmm 88 GPIO_ACTIVE_HIGH>; /* card detect gpio */ >> + vmmc-supply = <&vreg_l22a_2p96>; >> + vqmmc-supply = <&vreg_l5a_2p96>; >> + no-sdio; >> +}; >> + >> +&sleep_clk { >> + clock-frequency = <32000>; >> +}; >> + >> +&tlmm { >> + gpio-reserved-ranges = <37 5>, <43 2>, <47 1>, >> + <49 1>, <52 1>, <54 1>, >> + <56 3>, <61 2>, <64 1>, >> + <68 1>, <72 8>, <96 1>; >> +}; >> + >> +&uart4 { >> + status = "okay"; >> +}; >> + >> +&xo_board { >> + clock-frequency = <19200000>; >> +}; >> -- >> 2.38.1 >>