Re: [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shawn,

On 2023-03-14 00:28, Shawn Guo wrote:
On Thu, Mar 09, 2023 at 09:46:05PM +0100, Martin Kepplinger wrote:
From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@xxxxxxx>

This reduces power consumption in system suspend by about 10%.

Is there any other impact than this nice power gain?  Otherwise,
I would wonder why the quirk was enabled in the first place.


This comes from the early days of board bring-up and IIRC it seemed to stabilize flashing using the mfgtools over USB. Whatever gremlin was in those early boards is long gone and this is no longer needed.

Cheers
Angus

Shawn


Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@xxxxxxx>
Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxx>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 0b4b49fa1392a..f557632f574fa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1322,7 +1322,6 @@ &usb_dwc3_0 {
 	#address-cells = <1>;
 	#size-cells = <0>;
 	dr_mode = "otg";
-	snps,dis_u3_susphy_quirk;
 	usb-role-switch;
 	status = "okay";

--
2.30.2




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux