Hi, On Mon, 13 Mar 2023 at 09:31, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote: > > Hi Rob, > > On 10/3/23 15:46, Rob Herring wrote: > > It is preferred to use typed property access functions (i.e. > > of_property_read_<type> functions) rather than low-level > > of_get_property/of_find_property functions for reading properties. > > Convert reading boolean properties to to of_property_read_bool(). > > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > arch/mips/pci/pci-lantiq.c | 2 +- > > arch/mips/pci/pci-rt3883.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/mips/pci/pci-lantiq.c b/arch/mips/pci/pci-lantiq.c > > index d967e4c0cf24..79e29bf42a24 100644 > > --- a/arch/mips/pci/pci-lantiq.c > > +++ b/arch/mips/pci/pci-lantiq.c > > @@ -118,7 +118,7 @@ static int ltq_pci_startup(struct platform_device *pdev) > > > > /* and enable the clocks */ > > clk_enable(clk_pci); > > - if (of_find_property(node, "lantiq,external-clock", NULL)) > > + if (of_property_read_bool(node, "lantiq,external-clock")) > > Just curious, is this property correct? I can't find it and wonder if > this is dead code (always disabling the clock)... I'm probably missing > something obvious :/ > > > clk_enable(clk_external); > > else > > clk_disable(clk_external); The (whole) binding does seem to be undocumented, at least a quick grep didn't find anything for "lantiq,pci-xway" in bindings :-/ The property itself is used in OpenWrt though, e.g. https://github.com/openwrt/openwrt/blob/master/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/danube_arcadyan_arv7518pw.dts#L209 Regards Jonas
