On 10/03/2023 19:11, Uwe Kleine-König wrote: > On Mon, Feb 20, 2023 at 10:19:30PM +0100, Heiner Kallweit wrote: >> Convert Amlogic Meson PWM binding to yaml. >> >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> >> --- >> Seems patch got lost over the question who takes it. >> Please apply through the pwm tree. > > Hmm, I found > https://lore.kernel.org/linux-pwm/aaa73903-1837-d9c8-8c45-54b4473fd548@xxxxxxxxx > which had no Reviewed-by tag where Krzysztof Kozlowski replied writing: > "You got here a tag and my comment was about minor issue, so please keep > that tag." I didn't find a thread where such a tag was given, though. I > only found a review reply on v3 where Krzysztof requested a change (and > didn't provide a tag). > > The Reviewed-by tag for Rob probably originates from > https://lore.kernel.org/linux-pwm/20230130212121.GA3468100-robh@xxxxxxxxxx/. Yes, Rob provided that tag. Since it is included here, looks fine. > > And there is another variant where this patch was part of a series at > https://lore.kernel.org/linux-pwm/5b83767e-c53d-316f-df10-45a39dbd9c88@xxxxxxxxx > where it got an ack from me which wasn't included here. > > To fix this: > > Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > but please note that you can save some scarce maintainer time if you're > more careful here. Best regards, Krzysztof