Hello Samin, On Fri, Mar 03, 2023 at 04:59:16PM +0800, Samin Guo wrote: > This series adds ethernet support for the StarFive JH7110 RISC-V SoC. > The series includes MAC driver. The MAC version is dwmac-5.20 (from > Synopsys DesignWare). For more information and support, you can visit > RVspace wiki[1]. > > You can simply review or test the patches at the link [2]. > > This patchset should be applied after the patchset [3], [4], [5]. > [1]: https://wiki.rvspace.org/ > [2]: https://github.com/SaminGuo/linux/tree/vf2-6.2-gmac > [3]: https://lore.kernel.org/all/20230221024645.127922-1-hal.feng@xxxxxxxxxxxxxxxx/ > [4]: https://lore.kernel.org/all/20230202030037.9075-1-Frank.Sae@xxxxxxxxxxxxxx/ > [5]: https://lore.kernel.org/all/20230215113249.47727-5-william.qiu@xxxxxxxxxxxxxxxx/ Thanks for this series. I'm able to boot Linux over nfs into jh7110-starfive-visionfive-2-v1.3b board Tested-by: Tommaso Merciai <tomm.merciai@xxxxxxxxx> Regards, Tommaso > > Changes since v4: > - Supported both visionfive 2 v1.2A and visionfive 2 v1.3B. > - Reworded the maxitems number of resets property in 'snps,dwmac.yaml'. > - Suggested by Emil, dropped the _PLAT/_plat from the config/function/struct/file names. > - Suggested by Emil, added MODULE_DEVICE_TABLE(). > - Suggested by Emil, dropped clk_gtxclk and use clk_tx_inv to set the clock frequency. > - Added phy interface mode configuration function. > - Rebased on tag v6.2. > > Patch 12: > - No update > Patch 11: > - Configuration of gmac and phy for visionfive 2 v1.2A. > Patch 10: > - Configuration of gmac and phy for visionfive 2 v1.3B. > Patch 9: > - Added starfive,syscon for gmac nodes in jh7110.dtsi. > Patch 8: > - Added starfive_dwmac_set_mode to set PHY interface mode. > Patch 7: > - Added starfive,syscon item in StarFive-dwmac dt-bindings. > Patch 6: > - Moved SOC_STARFIVE to ARCH_STARFIVE in Kconfig. > - Dropped the _PLAT/_plat from the config/function/struct names. (by Emil) > - Added MODULE_DEVICE_TABLE() and udev will load the module automatically. (by Emil) > - Used { /* sentinel */ } for the last entry of starfive_eth_match. (by Emil) > - Added 'tx_use_rgmii_rxin_clk' to struct starfive_dwmac, to mark the clk_tx'parent is rgmii. > - Suggested by Emil, dropped clk_gtxclk and use clk_tx_inv to set the clock frequency. > Patch 5: > - Suggested by Emil, dropped mdio0/1 labels because there is no reference elsewhere. > Patch 4: > - Removed GTXC clk in StarFive-dwmac dt-bindings. > - Added starfive,tx-use-rgmii-clk item in StarFive-dwmac dt-bindings. > Patch 3: > - Added an optional reset single 'ahb' in 'snps,dwmac.yaml', according to > stmmac_probe_config_dt/stmmac_dvr_probe. > Patch 2: > - No update > Patch 1: > - No update > > Changes since v3: > - Reworded the maxitems number of resets property in 'snps,dwmac.yaml' > - Removed the unused code in 'dwmac-starfive-plat.c'. > - Reworded the return statement in 'starfive_eth_plat_fix_mac_speed' function. > > Changes since v2: > - Renamed the dt-bindings 'starfive,jh71x0-dwmac.yaml' to 'starfive,jh7110-dwmac.yaml'. > - Reworded the commit messages. > - Reworded the example context in the dt-binding 'starfive,jh7110-dwmac.yaml'. > - Removed "starfive,jh7100-dwmac" compatible string and special initialization of jh7100. > - Removed the parts of YT8531,so dropped patch 5 and 6. > - Reworded the maxitems number of resets property in 'snps,dwmac.yaml'. > > Changes since v1: > - Recovered the author of the 1st and 3rd patches back to Emil Renner Berthing. > - Added a new patch to update maxitems number of resets property in 'snps,dwmac.yaml'. > - Fixed the check errors reported by "make dt_binding_check". > - Renamed the dt-binding 'starfive,dwmac-plat.yaml' to 'starfive,jh71x0-dwmac.yaml'. > - Updated the example context in the dt-binding 'starfive,jh71x0-dwmac.yaml'. > - Added new dt-binding 'motorcomm,yt8531.yaml' to describe details of phy clock > delay configuration parameters. > - Added more comments for PHY driver setting. For more details, see > 'motorcomm,yt8531.yaml'. > - Moved mdio device tree node from 'jh7110-starfive-visionfive-v2.dts' to 'jh7110.dtsi'. > - Re-worded the commit message of several patches. > - Renamed all the functions with starfive_eth_plat prefix in 'dwmac-starfive-plat.c'. > - Added "starfive,jh7100-dwmac" compatible string and special init to support JH7100. > > Previous versions: > v1 - https://patchwork.kernel.org/project/linux-riscv/cover/20221201090242.2381-1-yanhong.wang@xxxxxxxxxxxxxxxx/ > v2 - https://patchwork.kernel.org/project/linux-riscv/cover/20221216070632.11444-1-yanhong.wang@xxxxxxxxxxxxxxxx/ > v3 - https://patchwork.kernel.org/project/linux-riscv/cover/20230106030001.1952-1-yanhong.wang@xxxxxxxxxxxxxxxx/ > v4 - https://patchwork.kernel.org/project/linux-riscv/cover/20230118061701.30047-1-yanhong.wang@xxxxxxxxxxxxxxxx/ > > Emil Renner Berthing (2): > dt-bindings: net: snps,dwmac: Add dwmac-5.20 version > net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string > > Samin Guo (8): > dt-bindings: net: snps,dwmac: Add an optional resets single 'ahb' > riscv: dts: starfive: jh7110: Add ethernet device nodes > net: stmmac: Add glue layer for StarFive JH7110 SoC > dt-bindings: net: starfive,jh7110-dwmac: Add starfive,syscon > net: stmmac: starfive_dmac: Add phy interface settings > riscv: dts: starfive: jh7110: Add syscon to support phy interface > settings > riscv: dts: starfive: visionfive-2-v1.3b: Add gmac+phy's delay > configuration > riscv: dts: starfive: visionfive-2-v1.2a: Add gmac+phy's delay > configuration > > Yanhong Wang (2): > dt-bindings: net: Add support StarFive dwmac > riscv: dts: starfive: visionfive 2: Enable gmac device tree node > > .../devicetree/bindings/net/snps,dwmac.yaml | 19 +- > .../bindings/net/starfive,jh7110-dwmac.yaml | 130 +++++++++++++ > MAINTAINERS | 7 + > .../jh7110-starfive-visionfive-2-v1.2a.dts | 13 ++ > .../jh7110-starfive-visionfive-2-v1.3b.dts | 27 +++ > .../jh7110-starfive-visionfive-2.dtsi | 10 + > arch/riscv/boot/dts/starfive/jh7110.dtsi | 93 ++++++++++ > drivers/net/ethernet/stmicro/stmmac/Kconfig | 12 ++ > drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + > .../ethernet/stmicro/stmmac/dwmac-starfive.c | 171 ++++++++++++++++++ > .../ethernet/stmicro/stmmac/stmmac_platform.c | 3 +- > 11 files changed, 481 insertions(+), 5 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c > > > base-commit: 11934a315b671ddb09bc7ac5f505649e9f2623c7 > prerequisite-patch-id: ad56ef54d3f2a18025abc9e27321c25beda16422 > prerequisite-patch-id: 1be0fb49e0fbe293ca8fa94601e191b13c8c67d9 > prerequisite-patch-id: 8b402a8d97294a9b568595816b0dc96afc5e6f5d > prerequisite-patch-id: 5c149662674f9e7dd888e2028fd8c9772948273f > prerequisite-patch-id: 0caf8a313a9f161447e0480a93b42467378b2164 > prerequisite-patch-id: b2422f7a12f1e86e38c563139f3c1dbafc158efd > prerequisite-patch-id: be612664eca7049e987bfae15bb460caa82eb211 > prerequisite-patch-id: 8300965cc6c55cad69f009da7916cf9e8ce628e7 > -- > 2.17.1 >