On 10/03/2023 04:48, Hermes Zhang wrote: > On 2023/3/9 18:12, Krzysztof Kozlowski wrote: >> On 09/03/2023 03:39, Hermes Zhang wrote: >>> Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag >>> in chip. Ignore TS pin will allow user to control the charging >>> parameters instead of the default JEITA profile in chip. >> You miss users of it. > Could you give some more info about what I missed? Users. DTS and driver code. >> @@ -68,6 +68,12 @@ properties: >> Interrupt sends an active low, 256 μs pulse to host to report the charger >> device status and faults. >> >> + ts-ignore: >> Missing vendor prefix... is this generic property? ts-ignore is very >> cryptic. You should describe here rather desired system characteristic. >> Why anyone would need to use it per-board level? > > OK, I will fix it. Will "ti,ignore-ts-pin" be better? No, because does not describe system characteristic. Read again my last two sentences. > Yes, it's a > generic. To disable the TS pin, actually we also could do it from HW, > but from software, it could be more flexble. But if HW already disable > it, then you don't need to do it again from dts. If this is configurable from HW, why this should be in DT? Best regards, Krzysztof
