On 09/03/2023 02:43, zhuyinbo wrote: > > 在 2023/3/8 下午6:38, Krzysztof Kozlowski 写道: >> On 08/03/2023 10:24, zhuyinbo wrote: >>>>>> That's an ABI break and commit msg does not explain it. >>>>> you meaning is that need add a explanation in commit msg that why >>>> You need good explanation to break the ABI. I don't understand the >>>> commit msg, but anyway I could not find there justification for ABI >>>> break. If you do not have good justification, don't break the ABI, >>> The commit msg is the patch commit log, and I maybe not got it about >>> break the ABI. You said about "break the ABI" >>> >>> is whether is location issue about "LOONGSON2_BOOT_CLK"? if yes, the >>> LOONGSON2_BOOT_CLK was placed >>> >>> after LOONGSON2_PIX1_PLL that is due to their clock parent is same. >>> and I whether need add this explanation >>> >>> in patch commit log description? >> Unfortunately I do not understand single thing from this. >> >> Best regards, >> Krzysztof > > The patch commit log description is patch desription. as follows: > > > commit 592bc2b4106d787ea166ba16bfde6b3101ab1a8a > Author: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> > Date: Tue Mar 7 17:18:32 2023 +0800 > > dt-bindings: clock: add loongson-2 boot clock index > > The Loongson-2 boot clock was used to spi and lio peripheral and > this patch was to add boot clock index number. I cannot understand this either. > > > and your advice is "That's an ABI break and commit msg does not explain it." > > I got it from your advice that was to add a explanation about > LOONGSON2_BOOT_CLK's > > location issue in patch description, right? ABI break needs justification, why do you think it is fine or who is/isn't affected etc. Your commit msg does not explain why ABI break is okay. It doesn't even explain to me why you need it. Best regards, Krzysztof
