Hi Angelo,
On Fri, 2023-03-03 at 12:35 +0100, AngeloGioacchino Del Regno wrote:
> Il 03/03/23 04:17, Allen-KH Cheng ha scritto:
> > Add display nodes and the GCE (Global Command Engine) properties
> > to the display nodes in order to enable the usage of the CMDQ
> > (Command Queue), which is required for operating the display.
> >
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@xxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 125
> > +++++++++++++++++++++++
> > 1 file changed, 125 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> > index b9d5af26771e..909f1a6ae108 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> > @@ -20,6 +20,13 @@
> > #address-cells = <2>;
> > #size-cells = <2>;
> >
> > + aliases {
> > + ovl = &ovl;
>
> Are you sure that this alias shouldn't be `ovl0 = &ovl` instead?
>
> > + ovl_2l= &ovl_2l;
>
> And this `ovl_2l0 = &ovl_2l` ?
>
> Everything else looks good.
>
> Regards,
> Angelo
>
Hmm, I think there is a small error here.
I either put index in aliases or don't write aliases since the
number of ovl and ovl_2l is one.
I will add 0 and upstae in next version.
Thanks,
Allen
Note:
in mtk_ddp_comp_get_id:
int id = of_alias_get_id(node, mtk_ddp_comp_stem[comp_type]);
(id < 0 || id == mtk_ddp_matches[i].alias_id)) return i;
