Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: fix memcpy's number of bytes in lvts_calibration_init()

Subject: Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: fix memcpy's number of bytes in lvts_calibration_init()
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Date: Wed, 8 Mar 2023 10:10:34 +0100
Cc: linux-pm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, khilman@xxxxxxxxxxxx, james.lo@xxxxxxxxxxxx, rex-bc.chen@xxxxxxxxxxxx
In-reply-to: <20230307134245.83599-1-bchihi@baylibre.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

Il 07/03/23 14:42, bchihi@xxxxxxxxxxxx ha scritto:

From: Balsam CHIHI <bchihi@xxxxxxxxxxxx>

Replace memcpy 2 bytes by sizeof(int) bytes of LVTS calibration data.


sizeof(int) is architecture dependant... please use a fixed size type instead.

Also, shouldn't this be u16?!

Regards,
Angelo

Follow-Ups:
- Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: fix memcpy's number of bytes in lvts_calibration_init()
  - From: Dan Carpenter

References:
- [PATCH v12 2/6] dt-bindings: thermal: mediatek: Add LVTS thermal controllers dt-binding definition
  - From: bchihi
- [PATCH] thermal/drivers/mediatek/lvts_thermal: fix memcpy's number of bytes in lvts_calibration_init()
  - From: bchihi