On 07/03/2023 16:35, Sean Anderson wrote: > Hi Krzysztof, > > On 3/7/23 03:42, Krzysztof Kozlowski wrote: >> On 06/03/2023 20:15, Sean Anderson wrote: >>> This is a generic binding for simple MMIO GPIO controllers. Although we >>> have a single driver for these controllers, they were previously spread >>> over several files. Consolidate them. The register descriptions are >>> adapted from the comments in the source. There is no set order for the >>> registers, so I have not specified one. >>> >>> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx> >>> --- >>> >>> Changes in v10: >>> - New >>> >>> .../bindings/gpio/brcm,bcm6345-gpio.yaml | 16 +-- >>> .../devicetree/bindings/gpio/gpio-mmio.yaml | 136 ++++++++++++++++++ >>> .../bindings/gpio/ni,169445-nand-gpio.txt | 38 ----- >>> .../devicetree/bindings/gpio/wd,mbl-gpio.txt | 38 ----- >>> 4 files changed, 137 insertions(+), 91 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-mmio.yaml >>> delete mode 100644 Documentation/devicetree/bindings/gpio/ni,169445-nand-gpio.txt >>> delete mode 100644 Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt >> >> https://lore.kernel.org/all/20230126-gpio-mmio-fix-v2-1-38397aace340@xxxxxxx/ > > Thanks for linking to that. > > I believe this patch should be applied instead of that one because > > - It documents all the registers, which were previously only documented > in the driver > - It handles the endianness properties. > - It consolidates the various descriptions of this binding into one > schema. Sure, sounds reasonable. You can just quickly check if my other comments apply here as well (but seems not): https://lore.kernel.org/all/4df3ec7a-e4af-89bc-9eda-21150395a935@xxxxxxxxxx/ Best regards, Krzysztof
