On 07/03/2023 07:29, SCHNEIDER Johannes wrote: > Hoi, > >> On 07/03/2023 05:44, Johannes Schneider wrote: >>> Add devicetree for the revision B imx8mm-EVK, which comes with a >>> different PMIC. >>> >>> The regulator min/max values are taken from the evk's schematic: >>> 8MMINILPD4-CPU SPF-31399_C2.pdf >>> >>> Reviewed-by: Shawn Guo <shawnguo@xxxxxxxxxx> >> Aren't you now adding fake tags? It's the second tag which was never >> given to you on LKML. >> >> Best regards, >> Krzysztof > > oooh, so i was too fast in adding this :-S > the reviewer also have to explicitly give these tags - giving review comments with requested changes isn't enough? No. We give many comments and how would ever that mean that the code is correct and we approve it? We talk here and you cannot create tags based on our talks! And even with that logic, why not Acked? Or anything else like "Looked-by:"? Really people should read submitting patches before sending... The tag comes with specific statement, so you cannot imply that statement. https://elixir.bootlin.com/linux/v5.19-rc1/source/Documentation/process/submitting-patches.rst#L513 Best regards, Krzysztof
