Hoi, >On 07/03/2023 05:44, Johannes Schneider wrote: >> Add devicetree for the revision B imx8mm-EVK, which comes with a >> different PMIC. >> >> The regulator min/max values are taken from the evk's schematic: >> 8MMINILPD4-CPU SPF-31399_C2.pdf >> >> Reviewed-by: Shawn Guo <shawnguo@xxxxxxxxxx> > Aren't you now adding fake tags? It's the second tag which was never > given to you on LKML. > >Best regards, > Krzysztof oooh, so i was too fast in adding this :-S the reviewer also have to explicitly give these tags - giving review comments with requested changes isn't enough? sorry for the confusion Johannes ________________________________________ From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Sent: Tuesday, March 7, 2023 07:25 To: SCHNEIDER Johannes; Shawn Guo Cc: Pengutronix Kernel Team; NXP Linux Team; devicetree@xxxxxxxxxxxxxxx; Rob Herring; Krzysztof Kozlowski; Sascha Hauer; Fabio Estevam; Li Yang; Shengjiu Wang; Richard Zhu; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH v12 1/2] arm64: dts: imx8mm-evk-revb: add support for i.MX8MM-EVK rev B This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email. On 07/03/2023 05:44, Johannes Schneider wrote: > Add devicetree for the revision B imx8mm-EVK, which comes with a > different PMIC. > > The regulator min/max values are taken from the evk's schematic: > 8MMINILPD4-CPU SPF-31399_C2.pdf > > Reviewed-by: Shawn Guo <shawnguo@xxxxxxxxxx> Aren't you now adding fake tags? It's the second tag which was never given to you on LKML. Best regards, Krzysztof
