Re: [PATCH] arm64: dts: rockchip: Lower sd speed on soquartz

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Den 05.03.2023 kl. 14.43 skrev Peter Geis:
On Sat, Mar 4, 2023 at 11:42 AM Dan Johansen <strit@xxxxxxxxxxx> wrote:
Just like the Quartz64 Model B the previously stated speed of sdr-104
in soquartz is too high for the hardware to reliably communicate with
some fast SD cards.
Especially on some carrierboards.

Lower this to sd-uhs-sdr50 to fix this.

Fixes: 5859b5a9c3ac ("arm64: dts: rockchip: add SoQuartz CM4IO dts")

Signed-off-by: Dan Johansen <strit@xxxxxxxxxxx>
Makes sense, considering the problems we're having with other boards.
We should probably stop using sdr104 altogether on Rockchip, at least
until they release a chip that improves on the limitations of pinctrl
speed. Considering the frequency cap it isn't that much of a hit.
I agree, better have a safe default.

Acked-by: Peter Geis <pgwipeout@xxxxxxxxx>
Thank you for the Ack.

---
  arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
index ce7165d7f1a1..102e448bc026 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
@@ -598,7 +598,7 @@ &sdmmc1 {
         non-removable;
         pinctrl-names = "default";
         pinctrl-0 = <&sdmmc1_bus4 &sdmmc1_cmd &sdmmc1_clk>;
-       sd-uhs-sdr104;
+       sd-uhs-sdr50;
         vmmc-supply = <&vcc3v3_sys>;
         vqmmc-supply = <&vcc_1v8>;
         status = "okay";
--
2.39.2


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
--
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux