On 02/03/2023 10:19, jack.zhu wrote: > Add DT binding document for Starfive Camera subsystem driver > > Signed-off-by: jack.zhu <jack.zhu@xxxxxxxxxxxxxxxx> > --- > .../bindings/media/starfive,jh7110-camss.yaml | 150 ++++++++++++++++++ > 1 file changed, 150 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > > diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > new file mode 100644 > index 000000000000..9a34944ca0ab > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > @@ -0,0 +1,150 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; Drop quotes from both. > + > +title: Starfive SoC CAMSS ISP > + > +maintainers: > + - Jack Zhu <jack.zhu@xxxxxxxxxxxxxxxx> > + - Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx> > + > +description: | No need for '|' > + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC.It > + consists of a VIN controller(Video In Controller, a top-level control until) > + and a ISP. "an ISP", I think > + > +properties: > + compatible: > + const: starfive,jh7110-camss > + > + reg: > + minItems: 2 Drop minItems, no need. > + maxItems: 2 > + > + reg-names: > + items: > + - const: syscon > + - const: isp > + > + clocks: > + minItems: 7 Drop mintems > + maxItems: 7 > + > + clock-names: > + items: > + - const: clk_apb_func > + - const: clk_wrapper_clk_c > + - const: clk_dvp_inv > + - const: clk_axiwr > + - const: clk_mipi_rx0_pxl > + - const: clk_ispcore_2x > + - const: clk_isp_axi Drop "clk" prefix > + > + resets: > + minItems: 6 Drop > + maxItems: 6 > + > + reset-names: > + items: > + - const: rst_wrapper_p Drop rst prefix > + - const: rst_wrapper_c > + - const: rst_axird > + - const: rst_axiwr > + - const: rst_isp_top_n > + - const: rst_isp_top_axi > + > + power-domains: > + items: > + - description: JH7110 PD ISP - ISP Power Domain Switch Controller. Drop redundant pieces, e.g. "PD ISP" > + > + interrupts: > + minItems: 4 Drop > + maxItems: 4 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@1: And what about port@0? > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port for receiving CSI data. > + > + properties: > + endpoint@1: Hm, do you have more than one endpoint in this port? Why unit address? > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + required: > + - port@1 > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - resets > + - reset-names > + - power-domains > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + Drop blank line > + stfcamss: camss@19840000 { isp@ > + compatible = "starfive,jh7110-camss"; > + reg = <0x19840000 0x10000>, > + <0x19870000 0x30000>; All this looks misaligned > + reg-names = "syscon", "isp"; > + clocks = <&ispcrg 0>, > + <&ispcrg 13>, Looks even worse... > + <&ispcrg 2>, > + <&ispcrg 12>, > + <&ispcrg 1>, > + <&syscrg 51>, > + <&syscrg 52>; > + clock-names = "clk_apb_func", > + "clk_wrapper_clk_c", > + "clk_dvp_inv", > + "clk_axiwr", > + "clk_mipi_rx0_pxl", > + "clk_ispcore_2x", > + "clk_isp_axi"; > + resets = <&ispcrg 0>, > + <&ispcrg 1>, > + <&ispcrg 10>, > + <&ispcrg 11>, > + <&syscrg 41>, > + <&syscrg 42>; > + reset-names = "rst_wrapper_p", > + "rst_wrapper_c", > + "rst_axird", > + "rst_axiwr", > + "rst_isp_top_n", > + "rst_isp_top_axi"; > + power-domains = <&pwrc 5>; > + interrupts = <92>, <87>, <88>, <90>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + vin_from_csi2rx: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&csi2rx_to_vin>; > + }; > + }; > + }; > + }; Best regards, Krzysztof
