> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] > Sent: 16 February 2023 16:24 > To: Shradha Todi <shradha.t@xxxxxxxxxxx>; lpieralisi@xxxxxxxxxx; > kw@xxxxxxxxx; robh@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; > jingoohan1@xxxxxxxxx; Sergey.Semin@xxxxxxxxxxxxxxxxxxxx; > lukas.bulwahn@xxxxxxxxx; hongxing.zhu@xxxxxxx; tglx@xxxxxxxxxxxxx; > m.szyprowski@xxxxxxxxxxx; jh80.chung@xxxxxxxxxx; > pankaj.dubey@xxxxxxxxxxx > Cc: linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 01/16] dt-bindings: PCI: Rename Exynos PCIe binding to > Samsung PCIe > > On 14/02/2023 13:13, Shradha Todi wrote: > > The current DT bindings is being used for Exynos5433 SoC only. > > In order to extend this binding for all SoCs manufactured by Samsung > > using DWC PCIe controller, renaming this file to a more generic name. > > Thank you for your patch. There is something to discuss/improve. > > > > > Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx> > > --- > > .../pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) rename > > Documentation/devicetree/bindings/pci/{samsung,exynos-pcie.yaml => > > samsung,pcie.yaml} (93%) > > > > diff --git > > a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > > b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml > > similarity index 93% > > rename from > > Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > > rename to Documentation/devicetree/bindings/pci/samsung,pcie.yaml > > index f20ed7e709f7..6cd36d9ccba0 100644 > > --- a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml > > We keep the name rather tied to compatible, not generic. There are no other > compatibles here, so I don't think we should rename it. > Our intention to rename was to have a common name for Samsung manufactured SoCs having PCIe controller. Though this change may not be a blocker for us but we feel it will be good to have a common name as this file will not have bindings only for Exynos series of SoC (Samsung Sys. LSI designed) but also custom ASICs such as FSD / ARTPEC SoC (Samsung Foundry designed). We hope we are not breaking any ABI as such in this patch. Shradha > Best regards, > Krzysztof
