> -----Original Message----- > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: 15 February 2023 00:48 > To: Shradha Todi <shradha.t@xxxxxxxxxxx> > Cc: lpieralisi@xxxxxxxxxx; kw@xxxxxxxxx; bhelgaas@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; > jingoohan1@xxxxxxxxx; Sergey.Semin@xxxxxxxxxxxxxxxxxxxx; > lukas.bulwahn@xxxxxxxxx; hongxing.zhu@xxxxxxx; tglx@xxxxxxxxxxxxx; > m.szyprowski@xxxxxxxxxxx; jh80.chung@xxxxxxxxxx; > pankaj.dubey@xxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required > property > > On Tue, Feb 14, 2023 at 05:43:27PM +0530, Shradha Todi wrote: > > To replace devm_of_phy_get with devm_phy_get to get the PHY pointer > > using non DT version, we need to add phy-names property in DT and make > > it a required property with const value. > > Also an ABI break. > > And unnecessary. You don't need a name with a single entry. Pretty sure I > fixed that for phy_get at some point. > Thanks, I got your point. I will drop this. As of now we have only single PHYs for Samsung and it can be handled via phy_get API without a name as you highlighted. Shradha > Rob
