Hi Marco, Am Montag, 27. Februar 2023, 11:57:10 CET schrieb Marco Felsch: > Hi Alexander, > > On 23-02-27, Alexander Stein wrote: > > Add FlexSPI node for i.MX93. > > > > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > > --- > > This is mainly taken from the downstream kernel with the clock order > > fixed and 'nxp,imx93-fspi' compatible removed. > > I do not know if it makes sense to add an imx93 specific compatible or > > not. imx8mn uses imx8mm only, but imx8mp has it's own. But the latter > > uses the same device data in the driver. > > > > arch/arm64/boot/dts/freescale/imx93.dtsi | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > > b/arch/arm64/boot/dts/freescale/imx93.dtsi index > > 3c3d3d570d8c..1d71ca8d1f5a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > > @@ -458,6 +458,21 @@ flexcan2: can@425b0000 { > > > > status = "disabled"; > > > > }; > > > > + flexspi1: spi@425e0000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "nxp,imx8mm-fspi"; > > + reg = <0x425e0000 0x10000>, <0x28000000 0x10000000>; > > The compatible should always be the first entry, followed by reg. Thanks for the feedback. I was wondering about this, but there is no consistency within this file :( Best regards, Alexander > Regards, > Marco > > > + reg-names = "fspi_base", "fspi_mmap"; > > + interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clk IMX93_CLK_FLEXSPI1_GATE>, > > + <&clk IMX93_CLK_FLEXSPI1_GATE>; > > + clock-names = "fspi_en", "fspi"; > > + assigned-clocks = <&clk IMX93_CLK_FLEXSPI1>; > > + assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD1>; > > + status = "disabled"; > > + }; > > + > > > > lpuart7: serial@42690000 { > > > > compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart"; > > reg = <0x42690000 0x1000>; -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/