On 23/02/2023 20:46, Johan Jonker wrote: > Add a unique hardware GPIO ID to the Rockchip GPIO nodes with > the "rockchip,gpio-controller" property to be independent from aliases > and probe order. "gpio-ranges" can't be used for that, because there is > no semantic restrictions on how they are set up. > > Signed-off-by: Johan Jonker <jbx6244@xxxxxxxxx> > --- > > See discussion: > https://lore.kernel.org/u-boot/CACRpkdZx8EaSFLeh4vruRsdC+Sx_ieBiKmuE7t37zhiYqtS3WQ@xxxxxxxxxxxxxx/ > --- > .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > index 2e9a5179c..39ac41e9d 100644 > --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > @@ -52,6 +52,12 @@ properties: > > gpio-line-names: true > > + rockchip,gpio-controller: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maximum: 8 > + description: > + Unique hardware GPIO ID. Neither commit msg nor this description explain why do you need it. Also: what is a unique ID? why only 8 of them are allowed? Why assigning arbitrary numbers should be a property of DT (answer: it's not)? Best regards, Krzysztof
