On 22/02/2023 19:09, Daniel Golle wrote: > The ethsys clocks of MT7981 and MT7986 are identical. In order to > de-duplicate both clock drivers, start with putting ethsys into a > header files of its own, so it can be used by both SoCs. > Propagate this change also to mt7986a.dtsi which is the only user. > > Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 1 + > drivers/clk/mediatek/clk-mt7986-eth.c | 2 +- > include/dt-bindings/clock/mediatek,ethsys.h | 32 +++++++++++++++++++ A bit too generic name. Are you sure it will fit all of eth on all Mediatek SoCs? Current and future? > .../dt-bindings/clock/mediatek,mt7981-clk.h | 18 ----------- > .../dt-bindings/clock/mediatek,mt7986-clk.h | 22 ------------- Same problems as previous patch. You cannot mix bindings and DTS and drivers. Best regards, Krzysztof
