Re: [PATCH v10 0/8] i2c-atr and FPDLink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 22, 2023 at 03:28:59PM +0200, Tomi Valkeinen wrote:
> Hi,
> 
> You can find v9 from:
> 
> https://lore.kernel.org/all/20230216140747.445477-1-tomi.valkeinen@xxxxxxxxxxxxxxxx/
> 
> Diff to v9 included below.
> 
> Main changes in v10:
> - Switch pre-increments to post-increments
> - Add macros for FPD3_RX_ID lengths
> - Use regmap_bulk_read in 16 bit reg accessors

Thanks!
I have no more remarks, nice job!

One thing below to just look at and if you want / have time / chance update.

...

> +	ret = regmap_bulk_read(priv->regmap, reg, &__v, 2);

sizeof()

...

> +	ret = regmap_bulk_read(priv->regmap, reg, &__v, 2);

Ditto.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux