On Thu, Feb 16, 2023 at 11:00:49AM +0100, Christian Marangi wrote: > On Wed, Feb 15, 2023 at 08:32:11PM -0600, Rob Herring wrote: > > > > On Thu, 16 Feb 2023 02:32:29 +0100, Christian Marangi wrote: > > > Document support for leds node in phy and add an example for it. > > > Phy led will have to match led-phy pattern and should be treated as a > > > generic led. > > > > > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > > > --- > > > .../devicetree/bindings/net/ethernet-phy.yaml | 22 +++++++++++++++++++ > > > 1 file changed, 22 insertions(+) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ethernet-phy.example.dtb: ethernet-phy@0: leds:led-phy@0:linux,default-trigger: 'oneOf' conditional failed, one must be fixed: > > 'netdev' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > > 'netdev' does not match '^mmc[0-9]+$' > > 'netdev' does not match '^cpu[0-9]*$' > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ethernet-phy.yaml > > > > Hi, I could be wrong but this should be fixed by the previous patch that > adds netdev to the trigger list. If so, then it didn't apply for me which is what PW says. So what tree does this series apply too? linux-next? That's a tree no one can apply patches from. Rob
