Re: [PATCH 2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 16, 2023 at 11:48 AM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>
>
>
> On 14.02.2023 17:12, Robert Marko wrote:
> > Align USB power GPIO hog node to DT schema.
> >
> > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> > ---
> Unless you submitted a separate patch for this, I only see
> hog being allowed in 845 TLMM.

No, cause there is a gpio-hog schema in dtschema and I did not
even look into the pinctrl bindings and dtbs_check is not throwing
a warning.

I dont really see a point further allowing it in pinctrl bindings.

Regards,
Robert
>
> Konrad
> >  arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> > index 38efd45433da5..cd2a32d0d5548 100644
> > --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> > @@ -76,7 +76,7 @@ mux_cs {
> >               };
> >       };
> >
> > -     usb-power {
> > +     usb-power-hog {
> >               line-name = "USB-power";
> >               gpios = <1 GPIO_ACTIVE_HIGH>;
> >               gpio-hog;



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@xxxxxxxxxx
Web: www.sartura.hr



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux