On 13/02/2023 10:21, Jeremy Kerr wrote: > Hi Krzysztof, > >> You should clearly communicate that driver is coming... > > OK. > >> Anyway binding comes with the driver, otherwise how can we check that >> you actually implemented it? > > I'll include this with the driver once we're past the RFC reviews. > >> Please send patches, not RFC. RFC means you are uncertain this is even >> correct and you ask for generic discussion. > > Yes, that's essentially what I'm looking for with this change - > particularly with the pullup config, which (as you say) could arguably > be a pinctrl config instead. Depends, there was just a short sentence. If this is external resistor on the board, why this device needs such property (and none of other devices need...)? If this is internal pull up of I3C (and there is no other pin configuration possible, no other pins), it looks reasonable to me to have it here. But I am all guessing it... Best regards, Krzysztof
