Hi Krzysztof, > You should clearly communicate that driver is coming... OK. > Anyway binding comes with the driver, otherwise how can we check that > you actually implemented it? I'll include this with the driver once we're past the RFC reviews. > Please send patches, not RFC. RFC means you are uncertain this is even > correct and you ask for generic discussion. Yes, that's essentially what I'm looking for with this change - particularly with the pullup config, which (as you say) could arguably be a pinctrl config instead. If we do decide to do this with pinctrl config, we'll need a separate driver (and minimal binding) for the global register set to act as the pin controller. That fundamentally changes the structure here - hence RFC. > generic discussion comment - implement how other recent i3c bindings > are implemented. This is basic device, there is nothing special here. I'd say the global register set makes the binding layout a bit quirky, as you've identified already. > Since you did not respond to rest of comments, I assume you are going > to implement them fully - including dropping the questioned > properties. Yep! Some of those will then be unneeded in this binding after going to a pinctrl approach, and I'll make the fixes as you suggested. Cheers, Jeremy
