> -----Original Message----- > From: Jia Jie Ho <jiajie.ho@xxxxxxxxxxxxxxxx> > Sent: 30 January, 2023 11:43 PM > To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>; David S . Miller > <davem@xxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Emil Renner Berthing > <kernel@xxxxxxxx>; Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-riscv@xxxxxxxxxxxxxxxxxxx > Subject: [PATCH v2 0/4] crypto: starfive - Add drivers for crypto engine > > This patch series adds kernel driver support for StarFive JH7110 crypto engine. > The first patch add Documentations for the device and Patch 2 adds device > probe and DMA init for the module. Patch 3 adds crypto and DMA dts node > for VisionFive 2 board. Patch 4 adds hash/hmac support to the module. > > Patch 3 needs to be applied on top of: > https://patchwork.kernel.org/project/linux- > riscv/patch/20221220011247.35560-7-hal.feng@xxxxxxxxxxxxxxxx/ > https://patchwork.kernel.org/project/linux- > riscv/cover/20230120024445.244345-1-xingyu.wu@xxxxxxxxxxxxxxxx/ > > Changes v1->v2: > - Fixed yaml filename and format (Krzysztof) > - Removed unnecessary property names in yaml (Krzysztof) > - Moved of_device_id table close to usage (Krzysztof) > - Use dev_err_probe for error returns (Krzysztof) > - Dropped redundant readl and writel wrappers (Krzysztof) > - Updated commit signed offs (Conor) > - Dropped redundant node in dts, module set to on in dtsi (Conor) > > Jia Jie Ho (4): > dt-bindings: crypto: Add StarFive crypto module > crypto: starfive - Add crypto engine support > riscv: dts: starfive: Add crypto and DMA node for VisionFive 2 > crypto: starfive - Add hash and HMAC support > > .../crypto/starfive,jh7110-crypto.yaml | 70 ++ > MAINTAINERS | 7 + > arch/riscv/boot/dts/starfive/jh7110.dtsi | 27 + > drivers/crypto/Kconfig | 1 + > drivers/crypto/Makefile | 1 + > drivers/crypto/starfive/Kconfig | 20 + > drivers/crypto/starfive/Makefile | 4 + > drivers/crypto/starfive/starfive-cryp.c | 238 ++++ > drivers/crypto/starfive/starfive-hash.c | 1095 +++++++++++++++++ > drivers/crypto/starfive/starfive-regs.h | 71 ++ > drivers/crypto/starfive/starfive-str.h | 99 ++ > 11 files changed, 1633 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml > create mode 100644 drivers/crypto/starfive/Kconfig create mode 100644 > drivers/crypto/starfive/Makefile create mode 100644 > drivers/crypto/starfive/starfive-cryp.c > create mode 100644 drivers/crypto/starfive/starfive-hash.c > create mode 100644 drivers/crypto/starfive/starfive-regs.h > create mode 100644 drivers/crypto/starfive/starfive-str.h > > -- > 2.25.1 Hi all, Could you please review this patch series? Or should I send a new version with Rob's sign-off on patch 1? Thank you in advance. Best regards, Jia Jie